場景:一個異步重算功能(任務新建后發送消息到RocketMq),每次重算單條記錄的時候,可以計算正確,但是當多條記錄批量重算時,結果總是莫名其妙的不對。排查了很久,終于找到原因
原因:在新建重算任務方法上添加了事務注解,而發送消息也在該方法中,導致事務未提交,消息已經發出去了。
源代碼:
@Transactionalpublic void updateGiftCostByTradeList(ShopShard shopShard, List<Trade> tradeList) {Preconditions.checkArgument(null != shopShard && !CollectionUtils.isEmpty(tradeList));for (Trade trade : tradeList) {if (TradeSpecialTypeEnum.getSpecialTypes().contains(trade.getTradeSpecialType())) {continue;}long giftCost = getGiftCostFromZhanggui(shopShard.getShopId(), trade);giftCost = giftCost > 0 ? giftCost : getGiftCostFromCaiwu(shopShard.getShopId(), trade);if ((trade.getGiftFee() == null ? 0 : trade.getGiftFee()) == giftCost) {continue;}tradeService.updateTradeGiftFee(shopShard.getShopId(), trade.getId(), giftCost);SendMsgToMqUtil.sendTradeMsgToTradeFeeTopic(rocketMqProducer, shopShard, trade);}}
更改后:
@Transactionalpublic void updateGiftCostByTradeList(ShopShard shopShard, List<Trade> tradeList) {Preconditions.checkArgument(null != shopShard && !CollectionUtils.isEmpty(tradeList));for (Trade trade : tradeList) {if (TradeSpecialTypeEnum.getSpecialTypes().contains(trade.getTradeSpecialType())) {continue;}long giftCost = getGiftCostFromZhanggui(shopShard.getShopId(), trade);giftCost = giftCost > 0 ? giftCost : getGiftCostFromCaiwu(shopShard.getShopId(), trade);if ((trade.getGiftFee() == null ? 0 : trade.getGiftFee()) == giftCost) {continue;}tradeService.updateTradeGiftFee(shopShard.getShopId(), trade.getId(), giftCost);}}private void doProcessCostRule(ShopShard shopShard, CostRule costRule) {
commonCostRuleService.updateGiftCostByTradeList(shopShard, pageInfo.getList());pageInfo.getList().forEach(trade -> {if (!recalStatPoolCommonServcie.sendMqToRecalStatPoolByTrade(trade, TradeStatRecalSourceEnum.GIFT_COST)) {log.error("process costRule trade send recalstatpool false shopId={}|trade={}", shopShard.getShopId(), JSON.toJSONString(trade));}});
}
?